Repository navigation
feat: allow profile routing overrides and revise presets - #26
Merged
Merged
Conversation
transparent-pegasus
marked this pull request as ready for review
November 10, 2026 21:38
transparent-pegasus
added a commit
that referenced
this pull request
Nov 17, 2026
…trator feat: allow profile routing overrides and revise presets
This was referenced Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
What problem are you trying to solve?
Profiles could select models but could not delegate planning or override routing settings. The smaller presets spent the upper model on execution instead of reserving it for planning and reviews.
What does this PR change?
Profiles now override present
fallbacks,delegation, andassignmentskeys, including individual task fields; omitted keys retain config/default values and lists replace, including[]. Shipsol-astraandopus-fablewith an explicit cheaper owner, upper-model planning/review, andplan-and-design.mode: delegate; rename both-panelpresets to-ultra. Synchronize the contract and its readers, and pass frozen effective pane scope to the lifecycle helper while keeping lifecycle permission config-only.Is this change appropriate for the core pack?
Yes. This extends the existing profile contract and shipped presets across supported consumers; it adds no service or dependency.
What alternatives did you consider?
Editing repository config for each preset would couple reusable profiles to local state. Adding a YAML runtime would duplicate the agent-interpreted contract; the existing helper instead accepts the frozen resolved scope.
Does this PR contain multiple unrelated changes?
No. Contract, presets, routing readers, lifecycle scope, packaging tests, and changelog implement the same profile behavior.
Existing PRs
Reviewed all open and closed PR titles for duplicates; no open PR covers this change. Related: #23, #24, #25. This continues #25, which was already merged, on the same
fix/generalist-orchestratorbranch.Environment tested
Tests execute the real shell helpers against the repository's offline Herdr stubs. No live pane, model-footer, or agent behavior sampling is claimed.
New harness support
Not applicable; no new harness support.
Evaluation
Initial request: continue #25 inline; add present-only profile routing overrides; revise presets; test, commit, push, and create a PR without merging. Final requested names, explicit Sol/Opus owners, and orchestrator-first key order are reflected below. Without an orchestrator entry, planning-design stays first; generalist stays last.
Live eval sessions: 0. Regression tests failed before implementation on old asset names, ignored resolved scope, and the old preset key order, then passed after the changes. Final results:
node --test tests/pane-model/pane.test.mjs tests/composer-submit/submit.test.mjs tests/orchestration-profiles/profiles.test.mjs tests/agent-lifecycle/lifecycle.test.mjs tests/opencode/plugin.test.mjs: 125/125 passed, no skips.bash tests/pane-model/run.sh: 26 passed.bash tests/pane-model/effort.sh: 45 passed.bash tests/pane-model/muse.sh: 22 passed.bash tests/skill-size/test-skill-size.sh: passed.claude plugin validate .claude-plugin/plugin.jsonandclaude plugin validate .: passed; warnings concern rootCLAUDE.mdcontext and the missing plugin icon.git diff --cached --check: clean..herdrpowers/.Rigor
Human review
Draft PR: human review is pending. The requester explicitly authorized uninterrupted execution through PR creation. Final review was author self-review; no independent review is claimed. Do not merge.
Changed files
Presets in full
sol-astra.yamlopus-fable.yamlfable-sol-ultra.yamlfable-opus-ultra.yamlsol-solo.yamlopus-solo.yaml